Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: make integV2 locally runnable #5029
tests: make integV2 locally runnable #5029
Changes from all commits
e50e3e7
9288c7a
74ed764
1deb608
edbbbed
aa3f69c
19763c2
9bbea65
f233f32
74a03ee
acf9c20
367cf7b
e473f7f
fce99c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In newer versions of python, set initialization is not stable. So each pytest worker process was iterating through
SSLYZE_SCANS_TO_TEST
in a different order, which means that the "test collection" list was not the same across processes. This causes a fatal error.Converting the set to a list makes a stable iteration order.