Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker cli to SMD #498

Open
wants to merge 1 commit into
base: release-2.1.0
Choose a base branch
from
Open

Add docker cli to SMD #498

wants to merge 1 commit into from

Conversation

cinlo
Copy link
Contributor

@cinlo cinlo commented Oct 17, 2024

Issue #, if available:

Description of changes:

  • Added the package to the {cpu/gpu}.additional_packages_env.in files
  • Added import test for the jupyter-activity-monitor-extension extension package
  • Built the images successfully and tested on the image. Results were as expected.

conda-forge: https://anaconda.org/conda-forge/docker-cli

Test results:

dev-dsk-cindyxl-2a-78c20928 % python -m pytest -n auto -m cpu -vv -rs -k "docker-cli" --local-image-version 2.1.0           
======================================================= test session starts =======================================================
platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0 -- /home/cindyxl/anaconda3/envs/sagemaker-distribution/bin/python
cachedir: .pytest_cache
rootdir: /local/home/cindyxl/workplace/CurrentProject/dockerSMD2/sagemaker-distribution
configfile: pytest.ini
plugins: mock-3.14.0, xdist-3.6.1
8 workers [1 item]      
scheduling tests via LoadScheduling

test/test_dockerfile_based_harness.py::test_dockerfiles_for_cpu[docker-cli.test.Dockerfile-required_packages30] 
[gw0] [100%] PASSED test/test_dockerfile_based_harness.py::test_dockerfiles_for_cpu[docker-cli.test.Dockerfile-required_packages30] 

======================================================== warnings summary =========================================================
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../../../../home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
  /home/cindyxl/anaconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH_NAIVE = datetime.utcfromtimestamp(0)

src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
  /local/home/cindyxl/workplace/CurrentProject/dockerSMD2/sagemaker-distribution/src/utils.py:4: DeprecationWarning: conda.cli.python_api is deprecated and will be removed in 25.9. Use `conda.testing.conda_cli` instead.
    import conda.cli.python_api

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================= 1 passed, 16 warnings in 11.68s =================================================
(sagemaker-distribution) 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@claytonparnell claytonparnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to confirm that the version here would work with Studio backend functionality, i.e. local mode

@claytonparnell
Copy link
Contributor

Local mode seems to work with this install, but I am seeing issue in the image when I run docker --version, it returns Docker version unknown-version, build unknown-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants