Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip invalid numbers when logging a metric or parameter #161

Merged
merged 1 commit into from
May 6, 2022

Conversation

jkasiraj
Copy link
Contributor

@jkasiraj jkasiraj commented May 5, 2022

Issue #, if available: 126

Description of changes: log a warning and skip numbers that aren't serializable (nan, inf, -inf) when logging a metric or parameter

Testing done: unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jkasiraj jkasiraj marked this pull request as ready for review May 5, 2022 01:19
@jkasiraj jkasiraj requested a review from a team as a code owner May 5, 2022 01:19
@jkasiraj jkasiraj merged commit d5df045 into aws:main May 6, 2022
@jkasiraj jkasiraj deleted the validation branch May 6, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants