Add support for additional tasks via HuggingFace TaskManager #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwang111
reviewed
Mar 1, 2024
src/sagemaker_huggingface_inference_toolkit/transformers_utils.py
Outdated
Show resolved
Hide resolved
philschmid
reviewed
Mar 2, 2024
samruds
force-pushed
the
PR
branch
6 times, most recently
from
511e150
to
3a17af2
Compare
samruds
commented
Mar 4, 2024
samruds
force-pushed
the
PR
branch
13 times, most recently
from
ad170f1
to
2689eb4
Compare
gwang111
reviewed
Mar 5, 2024
src/sagemaker_huggingface_inference_toolkit/transformers_utils.py
Outdated
Show resolved
Hide resolved
philschmid
reviewed
Mar 5, 2024
src/sagemaker_huggingface_inference_toolkit/transformers_utils.py
Outdated
Show resolved
Hide resolved
samruds
force-pushed
the
PR
branch
3 times, most recently
from
9021f08
to
58ac9f1
Compare
samruds
force-pushed
the
PR
branch
26 times, most recently
from
6a43011
to
d6a9584
Compare
philschmid
reviewed
Mar 7, 2024
Comment on lines
+231
to
+240
| if "HF_TASK" in os.environ: | ||
| return os.environ["HF_TASK"] | ||
| else: | ||
| with open(model_config_path, "r") as config_file: | ||
| config = json.loads(config_file.read()) | ||
| architecture = config.get("architectures", [None])[architecture_index] | ||
|
|
||
| for arch_options in ARCHITECTURES_2_TASK: | ||
| if architecture.endswith(arch_options): | ||
| task = ARCHITECTURES_2_TASK[arch_options] |
There was a problem hiding this comment.
I don't understand this change it is the exact same code as before, but you removed the error.
There was a problem hiding this comment.
Sorry Sam, I missed it. https://github.com/aws/sagemaker-huggingface-inference-toolkit/blame/80634b30703e8e9525db8b7128b05f713f42f9dc/src/sagemaker_huggingface_inference_toolkit/handler_service.py#L114 looks like the HF_TASK gets checked first before this function is even called.
Not sure why HF_TASK is being checked in this function then? Don't think we need to do anything. My bad
Please double check if i missed anything again
There was a problem hiding this comment.
Yep makes sense, I will close this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#112
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.