Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Conversation pipeline utils #130

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Remove Conversation pipeline utils #130

merged 1 commit into from
Aug 29, 2024

Conversation

ed-berry
Copy link
Contributor

Issue #129
Remove support for the deprecated Conversation pipeline that has been removed from transformers as of v4.42.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the pipeline

@philschmid
Copy link
Collaborator

@ed-berry can you run make style to make sure the CI passes?

Remove support for the deprecated Conversation pipeline that has been
removed from transformers as of v4.42. Fixes issue aws#129
@ed-berry
Copy link
Contributor Author

Hey @philschmid, looks like it was an unused import of pipeline in the tests. I've now removed this

@joann-alvarez
Copy link

Hello @philschmid! Is there someone else who needs to be tagged to approve for merging?

@philschmid philschmid merged commit 94b1d84 into aws:main Aug 29, 2024
2 checks passed
@joann-alvarez
Copy link

Thank you @ed-berry @philschmid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants