Fix: Move accelerate dependency closer to size calculations #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruds
force-pushed
the
accelerate-source
branch
2 times, most recently
from
36e0d7a to
0629384
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4502 +/- ##
==========================================
- Coverage 87.36% 87.35% -0.01%
==========================================
Files 389 389
Lines 36638 36639 +1
==========================================
- Hits 32007 32006 -1
- Misses 4631 4633 +2 ☔ View full report in Codecov by Sentry. |
samruds
force-pushed
the
accelerate-source
branch
10 times, most recently
from
cd2dd7a to
a15065b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
samruds
force-pushed
the
accelerate-source
branch
from
a15065b to
81e69eb
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Merged
9 tasks
samruds
force-pushed
the
accelerate-source
branch
6 times, most recently
from
5ca5bc7 to
ecd24ed
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
samruds
force-pushed
the
accelerate-source
branch
4 times, most recently
from
35c7f2c to
56836a1
Compare
samruds
force-pushed
the
accelerate-source
branch
6 times, most recently
from
650d40e to
e0c363e
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
samruds
force-pushed
the
accelerate-source
branch
2 times, most recently
from
d78726e to
3a62911
Compare
samruds
force-pushed
the
accelerate-source
branch
3 times, most recently
from
26c382a to
c4e6bea
Compare
samruds
force-pushed
the
accelerate-source
branch
from
c4e6bea to
e4780cd
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
benieric
approved these changes
Mar 20, 2024
malav-shastri
pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
* Fix: Move accelerate dependency closer to size calculations * Fix formatting * Minor update to description * Fix imports * Fix repr * move accelerate to utils
jiapinw
pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
* Fix: Move accelerate dependency closer to size calculations * Fix formatting * Minor update to description * Fix imports * Fix repr * move accelerate to utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.