Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hub model reference arn enum bug when constructing from arn #4972

Merged
merged 17 commits into from
Dec 30, 2024

Conversation

kc1998dp
Copy link
Contributor

@kc1998dp kc1998dp commented Dec 19, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kc1998dp kc1998dp changed the title Fix hub model reference arn enum bug Fix: hub model reference arn enum bug when constructing from arn Dec 19, 2024
@kc1998dp kc1998dp marked this pull request as ready for review December 19, 2024 18:54
@kc1998dp kc1998dp requested a review from a team as a code owner December 19, 2024 18:54
@kc1998dp kc1998dp requested a review from nileshvd December 19, 2024 18:54
Aditi2424
Aditi2424 previously approved these changes Dec 20, 2024
nileshvd
nileshvd previously approved these changes Dec 23, 2024
@kc1998dp kc1998dp deployed to manual-approval December 30, 2024 18:26 — with GitHub Actions Active
@sage-maker sage-maker merged commit 2102bb7 into aws:master Dec 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants