Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inputs and container artifacts for local mode trainer #4978

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Remove inputs and container artifacts for local mode trainer #4978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d4d8d7
Add an option for user to remove inputs and container artifacts when …
pintaoz-aws Dec 26, 2024
e50d681
fix tests
pintaoz-aws Dec 26, 2024
171ae9d
Merge branch 'master' into local-artifacts-cleanup
pintaoz-aws Dec 26, 2024
205f878
fix typo
pintaoz-aws Dec 27, 2024
2dcd3af
remove option
pintaoz-aws Dec 30, 2024
199c91c
Merge branch 'master' into local-artifacts-cleanup
pintaoz-aws Dec 31, 2024
cf7657b
Merge branch 'master' into local-artifacts-cleanup
pintaoz-aws Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/sagemaker/modules/local_core/local_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ class _LocalContainer(BaseModel):
container_entrypoint: Optional[List[str]]
container_arguments: Optional[List[str]]

_temporary_folders: List[str] = []

def model_post_init(self, __context: Any):
"""Post init method to perform custom validation and set default values."""
self.hosts = [f"algo-{i}" for i in range(1, self.instance_count + 1)]
Expand Down Expand Up @@ -201,6 +203,13 @@ def train(

# Print our Job Complete line
logger.info("Local training job completed, output artifacts saved to %s", artifacts)

shutil.rmtree(os.path.join(self.container_root, "input"))
shutil.rmtree(os.path.join(self.container_root, "shared"))
for host in self.hosts:
shutil.rmtree(os.path.join(self.container_root, host))
for folder in self._temporary_folders:
shutil.rmtree(os.path.join(self.container_root, folder))
return artifacts

def retrieve_artifacts(
Expand Down Expand Up @@ -540,6 +549,7 @@ def _get_data_source_local_path(self, data_source: DataSource):
uri = data_source.s3_data_source.s3_uri
parsed_uri = urlparse(uri)
local_dir = TemporaryDirectory(prefix=os.path.join(self.container_root + "/")).name
self._temporary_folders.append(local_dir)
download_folder(parsed_uri.netloc, parsed_uri.path, local_dir, self.sagemaker_session)
return local_dir
else:
Expand Down
23 changes: 11 additions & 12 deletions tests/integ/sagemaker/modules/train/test_local_model_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,7 @@ def test_single_container_local_mode_local_data(modules_sagemaker_session):
"compressed_artifacts",
"artifacts",
"model",
"shared",
"input",
"output",
"algo-1",
]

for directory in directories:
Expand Down Expand Up @@ -149,14 +146,16 @@ def test_single_container_local_mode_s3_data(modules_sagemaker_session):
assert os.path.exists(os.path.join(CWD, "compressed_artifacts/model.tar.gz"))
finally:
subprocess.run(["docker", "compose", "down", "-v"])

assert not os.path.exists(os.path.join(CWD, "shared"))
assert not os.path.exists(os.path.join(CWD, "input"))
assert not os.path.exists(os.path.join(CWD, "algo-1"))

directories = [
"compressed_artifacts",
"artifacts",
"model",
"shared",
"input",
"output",
"algo-1",
]

for directory in directories:
Expand Down Expand Up @@ -204,20 +203,20 @@ def test_multi_container_local_mode(modules_sagemaker_session):

model_trainer.train()
assert os.path.exists(os.path.join(CWD, "compressed_artifacts/model.tar.gz"))
assert os.path.exists(os.path.join(CWD, "algo-1"))
assert os.path.exists(os.path.join(CWD, "algo-2"))

finally:
subprocess.run(["docker", "compose", "down", "-v"])

assert not os.path.exists(os.path.join(CWD, "shared"))
assert not os.path.exists(os.path.join(CWD, "input"))
assert not os.path.exists(os.path.join(CWD, "algo-1"))
assert not os.path.exists(os.path.join(CWD, "algo-2"))

directories = [
"compressed_artifacts",
"artifacts",
"model",
"shared",
"input",
"output",
"algo-1",
"algo-2",
]

for directory in directories:
Expand Down
Loading