chore: actually exclude test files from being installed#1132
Merged
jlhood merged 1 commit intoaws:developfrom Sep 19, 2019
yan12125:exclude-tests
Merged
chore: actually exclude test files from being installed#1132jlhood merged 1 commit intoaws:developfrom yan12125:exclude-tests
jlhood merged 1 commit intoaws:developfrom
yan12125:exclude-tests
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1132 +/- ##
=======================================
Coverage 94.8% 94.8%
=======================================
Files 71 71
Lines 3486 3486
Branches 680 680
=======================================
Hits 3305 3305
Misses 93 93
Partials 88 88Continue to review full report at Codecov.
|
praneetap
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
In Arch Linux, we build python-aws-sam-translator package from sources. Before this change, test files are installed:
This is a problem as the directory
/usr/lib/python3.7/site-packages/testsconflicts with other packages.Description of how you validated changes:
After this change, there are no longer test files
Checklist:
make prpassesexamples/2016-10-31I think these checks are irrelevant are this is a packaging fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.