Changes for EventBusName on CW Event#1185
Merged
ShreyaGangishetty merged 2 commits intoaws:developfrom Oct 8, 2019
Merged
Conversation
zbintliff
force-pushed
the
feature/eventbridge-function
branch
from
cf5f8fe to
64e9a7f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1185 +/- ##
===========================================
+ Coverage 94.33% 94.33% +<.01%
===========================================
Files 72 72
Lines 3724 3725 +1
Branches 733 733
===========================================
+ Hits 3513 3514 +1
Misses 107 107
Partials 104 104
Continue to review full report at Codecov.
|
Contributor
Author
|
sorry let me rebase it off of develop |
Resolve tests
zbintliff
force-pushed
the
feature/eventbridge-function
branch
from
64e9a7f to
064b628
Compare
Contributor
|
@zbintliff Thanks for the contribution! Please reach out if you need help. You can update this example and add documentation here and we can get started on the review. |
jlhood
approved these changes
Oct 8, 2019
Contributor
jlhood
left a comment
jlhood
left a comment
There was a problem hiding this comment.
Looks great! Thanks so much for contributing this!
ShreyaGangishetty
approved these changes
Oct 8, 2019
|
The PR looks good! Approved and merged it. Thanks for contributing this! |
praneetap
pushed a commit
to praneetap/serverless-application-model
that referenced
this pull request
Dec 1, 2019
ShreyaGangishetty
pushed a commit
to ShreyaGangishetty/serverless-application-model
that referenced
this pull request
Dec 2, 2019
ShreyaGangishetty
pushed a commit
that referenced
this pull request
Dec 2, 2019
feat: changes for eventbusname on cloudwatch event (#1185)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1067
Description of changes:
Add field
EventBusNameto events that are triggers to functionsDescription of how you validated changes:
Changes the input yaml and output CFN Templates to make sure it was put correctly. Even though it is supporting the "EventBridge" service the field is called "EventBusName" on the rule
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.