feat: Add support for TriggerConfigurations in DeploymentConfiguration#1195
Merged
ShreyaGangishetty merged 5 commits intoaws:developfrom Oct 25, 2019
Merged
Conversation
added 3 commits
October 12, 2019 17:07
Update tests to cover new code
Documentation and example update
Codecov Report
@@ Coverage Diff @@
## develop #1195 +/- ##
===========================================
+ Coverage 94.33% 94.43% +0.09%
===========================================
Files 72 72
Lines 3725 3736 +11
Branches 733 739 +6
===========================================
+ Hits 3514 3528 +14
+ Misses 107 105 -2
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
ShreyaGangishetty
approved these changes
Oct 24, 2019
ShreyaGangishetty
left a comment
ShreyaGangishetty
left a comment
There was a problem hiding this comment.
@cakepietoast Thank you for contributing this feature!
jlhood
suggested changes
Oct 24, 2019
Contributor
jlhood
left a comment
jlhood
left a comment
There was a problem hiding this comment.
This is a great feature! Have some minor doc comments, but the functional code looks good.
Improve documentation reference for trigger config. Co-Authored-By: James Hood <james@jlhood.com>
Remove erroneous comment in documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #955
Description of changes: Add support for trigger configurations on deployment preference resources.
Description of how you validated changes: Unit tests, test translate & deploy with a simple template making use of the new TriggerConfig parameter in DeploymentConfig.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.