[docs] fix CORS documentation regarding API Gateway literal values#1198
Merged
keetonian merged 1 commit intoaws:developfrom Oct 17, 2019
Merged
[docs] fix CORS documentation regarding API Gateway literal values#1198keetonian merged 1 commit intoaws:developfrom
keetonian merged 1 commit intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1198 +/- ##
========================================
Coverage 94.33% 94.33%
========================================
Files 72 72
Lines 3725 3725
Branches 733 733
========================================
Hits 3514 3514
Misses 107 107
Partials 104 104Continue to review full report at Codecov.
|
ShreyaGangishetty
approved these changes
Oct 16, 2019
|
Thank you for fixing this! |
keetonian
approved these changes
Oct 17, 2019
Contributor
keetonian
left a comment
keetonian
left a comment
There was a problem hiding this comment.
Ran into a question on this recently. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1172
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.