Conversation
fix sns publish. was using sqs. from `aws sqs send-message` to `aws sns publish`
Codecov Report
@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
+ Coverage 94.33% 94.36% +0.03%
===========================================
Files 72 71 -1
Lines 3725 3621 -104
Branches 733 713 -20
===========================================
- Hits 3514 3417 -97
+ Misses 107 104 -3
+ Partials 104 100 -4
Continue to review full report at Codecov.
|
ShreyaGangishetty
approved these changes
Oct 15, 2019
ShreyaGangishetty
left a comment
There was a problem hiding this comment.
Thank you for fixing this !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix sns publish. was using sqs. from
aws sqs send-messagetoaws sns publishIssue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.