bug fix for authorizer none when using swagger#1211
Merged
keetonian merged 3 commits intoaws:developfrom Oct 17, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1211 +/- ##
===========================================
+ Coverage 94.33% 94.41% +0.08%
===========================================
Files 72 72
Lines 3725 3725
Branches 733 736 +3
===========================================
+ Hits 3514 3517 +3
+ Misses 107 105 -2
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
jlhood
suggested changes
Oct 17, 2019
Contributor
jlhood
left a comment
jlhood
left a comment
There was a problem hiding this comment.
Just some file renaming. Otherwise, this looks good!
jlhood
approved these changes
Oct 17, 2019
keetonian
approved these changes
Oct 17, 2019
keetonian
changed the title
ShreyaGangishetty
pushed a commit
to ShreyaGangishetty/serverless-application-model
that referenced
this pull request
Jan 2, 2020
…)" This reverts commit fefc61f.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#984
Description of changes:
SAM didn't update the swagger with Authorizer: NONE if user has defined the swagger.
added a code fix for updating the swagger for this.
Description of how you validated changes:
manually deployed and tested the template
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.