fix: throw better error for improper api reference#1224
Merged
ShreyaGangishetty merged 1 commit intoaws:developfrom Nov 9, 2019
Merged
fix: throw better error for improper api reference#1224ShreyaGangishetty merged 1 commit intoaws:developfrom
ShreyaGangishetty merged 1 commit intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1224 +/- ##
===========================================
+ Coverage 94.43% 94.43% +<.01%
===========================================
Files 72 72
Lines 3736 3738 +2
Branches 739 740 +1
===========================================
+ Hits 3528 3530 +2
Misses 105 105
Partials 103 103
Continue to review full report at Codecov.
|
praneetap
approved these changes
Nov 7, 2019
ShreyaGangishetty
approved these changes
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1038
Description of changes:
Fixes an uncaught error if the RestApiId property contains a dictionary (like an import value statement). SAM does not yet support referencing an Api outside of the current template.
Description of how you validated changes:
Tests written, updated, and pass
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.