Adding VPC Access Policy when VpcConfig is present#1228
Merged
praneetap merged 2 commits intoaws:developfrom Nov 27, 2019
Merged
Adding VPC Access Policy when VpcConfig is present#1228praneetap merged 2 commits intoaws:developfrom
praneetap merged 2 commits intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1228 +/- ##
===========================================
+ Coverage 94.48% 94.49% +<.01%
===========================================
Files 72 72
Lines 3738 3740 +2
Branches 740 741 +1
===========================================
+ Hits 3532 3534 +2
Misses 104 104
Partials 102 102
Continue to review full report at Codecov.
|
|
@eugeniosu Thank you contributing this! |
ShreyaGangishetty
force-pushed
the
develop
branch
from
e2e7f70 to
f47abe0
Compare
ShreyaGangishetty
approved these changes
Nov 12, 2019
ShreyaGangishetty
left a comment
ShreyaGangishetty
left a comment
There was a problem hiding this comment.
I have resolved the merge conflicts.
This PR looks good to me!
praneetap
approved these changes
Nov 27, 2019
Contributor
praneetap
left a comment
praneetap
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1169
Description of changes:
The managed policy
service-role/AWSLambdaVPCAccessExecutionRoleis added when the propertyVpcConfigis present .Description of how you validated changes:
I updated the tests to check that the generated role contains
service-role/AWSLambdaVPCAccessExecutionRoleChecklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.