fix: adding support to point to api gateway distribution #1230
Merged
ShreyaGangishetty merged 2 commits intoaws:developfrom Nov 1, 2019
Merged
fix: adding support to point to api gateway distribution #1230ShreyaGangishetty merged 2 commits intoaws:developfrom
ShreyaGangishetty merged 2 commits intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1230 +/- ##
===========================================
+ Coverage 94.43% 94.48% +0.05%
===========================================
Files 72 72
Lines 3736 3735 -1
Branches 739 739
===========================================
+ Hits 3528 3529 +1
+ Misses 105 104 -1
+ Partials 103 102 -1
Continue to review full report at Codecov.
|
keetonian
reviewed
Oct 31, 2019
| --capabilities CAPABILITY_IAM | ||
| ``` | ||
|
|
||
| Curl to the endpoint "http://example.com/home/fetch" should hit the Api. No newline at end of file |
Contributor
There was a problem hiding this comment.
home is the base path and fetch is the api path, correct? That's what it looks like looking at the example template, just want to make sure I understand this.
keetonian
approved these changes
Oct 31, 2019
ShreyaGangishetty
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Found an issue where we don't support using the distribution supported by apigateway for custom domains.
Description of changes:
Description of how you validated changes:
validated end to end
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.