Add Python 3.8 as supported#1256
Merged
keetonian merged 1 commit intoaws:developfrom Dec 5, 2019
gliptak:python38
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 94.43% 94.49% +0.05%
==========================================
Files 71 71
Lines 3630 3669 +39
Branches 717 717
==========================================
+ Hits 3428 3467 +39
Misses 103 103
Partials 99 99
Continue to review full report at Codecov.
|
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Contributor
Author
|
@ShreyaGangishetty the PR is green |
ShreyaGangishetty
approved these changes
Dec 4, 2019
ShreyaGangishetty
left a comment
There was a problem hiding this comment.
@gliptak Thank you for contributing this!
This PR looks good to me
keetonian
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#945
Thank you for the ping @jpangburn
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.