Allow kinesis:DescribeStreamSummary for KinesisCrudPolicy and KinesisReadStreamPolicy#1259
Merged
ShreyaGangishetty merged 1 commit intoaws:developfrom Dec 6, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1259 +/- ##
===========================================
+ Coverage 94.49% 95.26% +0.76%
===========================================
Files 72 72
Lines 3745 4373 +628
Branches 741 1003 +262
===========================================
+ Hits 3539 4166 +627
Misses 104 104
- Partials 102 103 +1
Continue to review full report at Codecov.
|
praneetap
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
@michaeljfazio Could you please update this PR by removing this commit from this PR
Contributor
Author
There was a problem hiding this comment.
Rebased back off the release tag now to avoid picking up the change that introduced it. Should be good to go now.
…StreamReadPolicy Resolves issue aws#1251
ShreyaGangishetty
approved these changes
Dec 6, 2019
ShreyaGangishetty
left a comment
There was a problem hiding this comment.
@michaeljfazio Thank you for contributing this!! This PR looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #1251
Added kinesis:DescribeStreamSummary action to KinesisCrudPolicy and KinesisReadStreamPolicy
Validated via unit test.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.