fix: Transform Cognito Events to a Permission with SourceArn#1260
Merged
ShreyaGangishetty merged 1 commit intoaws:developfrom Dec 5, 2019
chrisoverzero:feature/cognito-source-arn
Merged
fix: Transform Cognito Events to a Permission with SourceArn#1260ShreyaGangishetty merged 1 commit intoaws:developfrom chrisoverzero:feature/cognito-source-arn
SourceArn#1260ShreyaGangishetty merged 1 commit intoaws:developfrom
chrisoverzero:feature/cognito-source-arn
Conversation
...rather than one with `EventSourceToken`.
Codecov Report
@@ Coverage Diff @@
## develop #1260 +/- ##
===========================================
+ Coverage 94.48% 94.49% +<.01%
===========================================
Files 72 72
Lines 3738 3739 +1
Branches 740 740
===========================================
+ Hits 3532 3533 +1
Misses 104 104
Partials 102 102
Continue to review full report at Codecov.
|
chrisoverzero
changed the title
SourceArnSourceArn
praneetap
approved these changes
Dec 5, 2019
Contributor
praneetap
left a comment
praneetap
left a comment
There was a problem hiding this comment.
@chrisoverzero Thanks for contributing this PR!
ShreyaGangishetty
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #1253.
Description of changes:
When the
AWS::Lambda::Permissionresource was created for a Cognito event, it used theEventSourceTokenproperty. This caused authentication (or, in my case, pre-authentication) events to fail to execute "due to errorAccessDeniedException". This PR changes that to theSourceArnproperty.Description of how you validated changes:
I deployed a transformed template of one of my applications and attempted to authenticate. I succeeded. 🎉
Checklist:
make prpassesUpdate documentationAdd/update example toexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.