feat(policy-template): adding cloudwatch:describeAlarmHistory policy …#1304
Closed
ShreyaGangishetty wants to merge 1 commit intodevelopfrom
Closed
feat(policy-template): adding cloudwatch:describeAlarmHistory policy …#1304ShreyaGangishetty wants to merge 1 commit intodevelopfrom
ShreyaGangishetty wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
Note: requires a merge commit rather than a squash+merge. |
keetonian
approved these changes
Dec 6, 2019
Contributor
|
Can you fix the failing tests? Looks like there are some policy template differences you need to pick up on develop. |
Author
|
@keetonian I will check and fix failing tests. Thank you |
5 tasks
Author
|
@keetonian Please review #1306 . Closing this in favor of #1306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#1264)
Issue #, if available:
Merged #1264 into master instead of develop.
Description of changes:
This PR is to merge #1264 into develop and I will submit another PR to revert #1264 from master
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.