fix: Deduplicate error message in InvalidResourceException #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
aaythapa
approved these changes
Dec 16, 2022
acristin
approved these changes
Dec 16, 2022
hoffa
reviewed
Dec 16, 2022
Comment on lines
110
to
+111
| "Events": PropertyType(False, dict_of(is_str(), is_type(dict))), | ||
| "Tags": PropertyType(False, is_type(dict)), | ||
| "Tags": PropertyType.optional_dict(), |
There was a problem hiding this comment.
I find this harder to read.
Now we have a mix of PropertyType(... is_type(dict)), PropertyType.optional_dict(), etc. It's clear what this all is, why pick one over there, or why optional dicts are special.
There was a problem hiding this comment.
yeah, need a follow up to replace others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
This also make optional dict PropertyType
sam_resources.pyall with better validation error messages.Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.