Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New opt-in property to update Lambda version whenever a property changes #2838

Merged
merged 23 commits into from
Feb 1, 2023
Merged

feat: New opt-in property to update Lambda version whenever a property changes #2838

merged 23 commits into from
Feb 1, 2023

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Jan 31, 2023 •
edited by hoffa
Loading

Issue #, if available

#413

Description of changes

Add a new opt in property that will update a lambda version whenever a property in the transformed lambda function changes.

Description of how you validated changes

Used integrations tests. Pushed a template with AutoPublishAliasAllProperties set to True, then changed the handler property and made sure a new lambda version was created

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa marked this pull request as ready for review January 31, 2023 21:14
@aaythapa aaythapa requested a review from a team as a code owner January 31, 2023 21:14
ConnorRobertson
ConnorRobertson approved these changes Jan 31, 2023
View reviewed changes
Copy link

@ConnorRobertson ConnorRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hoffa
hoffa reviewed Jan 31, 2023
View reviewed changes
schema_source/aws_serverless_function.py Outdated Show resolved Hide resolved
samtranslator/model/sam_resources.py Outdated Show resolved Hide resolved
samtranslator/model/sam_resources.py Outdated Show resolved Hide resolved
@aaythapa aaythapa requested a review from hoffa February 1, 2023 19:50
@hoffa hoffa requested a review from aahung February 1, 2023 19:58
aahung
aahung reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where AutoPublishAliasAllProperties's value is an intrinsic. Sometimes customers will try to use intrinsics and in current logics, it looks like we will treat it as True if no validation errors are raised.

@aaythapa aaythapa requested a review from aahung February 1, 2023 21:08
ConnorRobertson
ConnorRobertson approved these changes Feb 1, 2023
View reviewed changes
Copy link

@ConnorRobertson ConnorRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaythapa aaythapa merged commit bcbbdc3 into aws:develop Feb 1, 2023
@aaythapa aaythapa mentioned this pull request Feb 15, 2023
Closed
@aidansteele aidansteele mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffa hoffa hoffa approved these changes

@ConnorRobertson ConnorRobertson ConnorRobertson approved these changes

@ssenchenko ssenchenko ssenchenko approved these changes

@aahung aahung aahung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaythapa @hoffa @aahung @ssenchenko @ConnorRobertson