ci: Remove pylint #2843
Merged
ci: Remove pylint #2843
+13
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Feb 1, 2023
xazhao
approved these changes
Feb 1, 2023
ssenchenko
approved these changes
Feb 1, 2023
hoffa
reviewed
Feb 1, 2023
…nefit the team to make code better
hoffa
approved these changes
Feb 1, 2023
GavinZZ
approved these changes
Feb 1, 2023
ConnorRobertson
approved these changes
Feb 1, 2023
|
Sorry for the drive-by but this is really cool to see and I'm glad Ruff is working for you. Always feel free to file Issues etc. as they come up, I try to be very responsive :) |
|
@charliermarsh thanks for working on this amazing tool |
|
@charliermarsh FYI the SAM CLI team is also moving toward Ruff (see e.g. aws/aws-lambda-builders#435). Thanks a lot for working on this, my eyes have been opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Ruff's stability is proven and adopted by many large projects (see README). So far ruff has been catching a lot of code issues in previous PRs. At by removing pylint we can save a minute or two in CI/CD for each build, each python version.
Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.