Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GH Action to detect compatibility breaking chages #2877

Merged
merged 22 commits into from
Feb 9, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Feb 9, 2023

Issue #, if available

Description of changes

Description of how you validated changes

I created another PR draft to test it: #2878 (comment)

image

The test GH action run: https://github.com/aws/serverless-application-model/actions/runs/4130070494

Apparently it doesn't catch all the breaking changes, I will investigate it in a follow up

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung force-pushed the interface-check-gh-action branch from 295577b to afffab3 Compare February 9, 2023 00:16
@aahung aahung marked this pull request as ready for review February 9, 2023 01:20
@aahung aahung requested a review from a team as a code owner February 9, 2023 01:20
@aahung aahung requested a review from hoffa February 9, 2023 01:20
@aahung aahung enabled auto-merge (squash) February 9, 2023 01:28
@aahung aahung merged commit 633ce6a into develop Feb 9, 2023
@aahung aahung deleted the interface-check-gh-action branch February 9, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants