feat: new SESBulkTemplatedCrudPolicy_v2 policy #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
approved these changes
Feb 22, 2023
ssenchenko
requested changes
Feb 23, 2023
awood45
requested changes
Feb 23, 2023
ssenchenko
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
After discussions with @SimonCMoore and @hoffa I think it's okay to have it all in a single plain json object
|
Waiting on security approval |
awood45
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#2844
Description of changes
Added a new version of the
SESBulkTemplatedCrudPolicypolicy.SESBulkTemplatedCrudPolicy_v2is same but with template arn added to the resource section.Description of how you validated changes
Made an example template and manually changed the policy to include the template arn in the resource section. No errors showed.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.