codegen: Introduce the concept of a NullableIndex and Pointable Index #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
denseListMap
branch
7 times, most recently
from
bf2950d to
deb1e58
Compare
jasdel
force-pushed
the
denseListMap
branch
2 times, most recently
from
5a86eac to
2d2cb3f
Compare
skmcgrail
suggested changes
Nov 12, 2020
...y-go-codegen/src/main/java/software/amazon/smithy/go/codegen/knowledge/GoPointableIndex.java
Outdated
Show resolved
Hide resolved
...y-go-codegen/src/main/java/software/amazon/smithy/go/codegen/knowledge/GoPointableIndex.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
...n/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ShapeValueGenerator.java
Outdated
Show resolved
Hide resolved
...n/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ShapeValueGenerator.java
Outdated
Show resolved
Hide resolved
...n/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ShapeValueGenerator.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SymbolVisitor.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SymbolVisitor.java
Show resolved
Hide resolved
skmcgrail
reviewed
Nov 13, 2020
...hy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/ProtocolUtils.java
Outdated
Show resolved
Hide resolved
skmcgrail
approved these changes
Nov 13, 2020
skotambkar
approved these changes
Nov 14, 2020
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/CodegenUtils.java
Show resolved
Hide resolved
...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/GoValueAccessUtils.java
Outdated
Show resolved
Hide resolved
...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/GoValueAccessUtils.java
Outdated
Show resolved
Hide resolved
...c/main/java/software/amazon/smithy/go/codegen/integration/HttpProtocolUnitTestGenerator.java
Outdated
Show resolved
Hide resolved
...codegen/src/main/java/software/amazon/smithy/go/codegen/integration/ValidationGenerator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new KnowedgeIndex implementation
GoPointableIndexthis index declares when a shape should be a pointer or value type in Go code. Updates the SDK's code generation so that all non-sparse list and maps are rendered with value members instead of pointers. This null-ability applies to number and boolean members to that are not explicitly decorated as boxed.TODO
Fixes #128
Fixes #127
Fixes #149