Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds waiter support to smithy-go #237

Merged
merged 23 commits into from
Dec 10, 2020
Merged

Adds waiter support to smithy-go #237

merged 23 commits into from
Dec 10, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Dec 1, 2020

While reviewing, please also review the generated waiters for weather service: https://gist.github.com/skotambkar/73f4f0825f9960fa29834753f1f59c30. (updated)

Description of changes:

  • Adds support for waitable trait.

TODO:
[x] move waiter middleware to be waiter-specific and code generated. This is required to remove the use of empty interfaces on waiter state mutator options.
[x] Test waiter generation with weather service.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jasdel
Copy link
Contributor

jasdel commented Dec 2, 2020

Probably https://gist.github.com/skotambkar/e4d4ff1404df8f78c598a9471f9212a4#file-listcitieswaiter-go-L7-L32 needs a APIOptions member to provide additional api options like stack mutators.

waiter/waiter_test.go Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
waiter/waiter_test.go Outdated Show resolved Hide resolved
waiter/waiter.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants