add support for withHelper for config field #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Jan 20, 2021
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(getName(), getType(), getDocumentation()); | ||
| return Objects.hash(getName(), getType(), getDocumentation(), withHelper()); |
There was a problem hiding this comment.
Should this follow the getter naming pattern? getWithHelper?
There was a problem hiding this comment.
I think with is self sufficient here, adding get seems redundant.
There was a problem hiding this comment.
The pattern for retrieving private fields in java is to prefix with get<FieldName>. It's ambiguous name makes it sound like a setter instead, or a builder helper.
There was a problem hiding this comment.
given the java naming scheme probably better to add a get prefix since its the java style. When this was original added, I wasn't following the Java naming, and used the implicit behavior.
There was a problem hiding this comment.
Alright, updated!
skotambkar
force-pushed
the
WithHelperAddition
branch
from
ee302e2
to
e8f79b0
Compare
skmcgrail
approved these changes
Jan 22, 2021
jasdel
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Config field to support withHelper option it partially supports. The withHelper option is used to generate a With-Helper function for a Config Field.