Add method to get successful output from waiters #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
added a commit
to haines/aws-sdk-go-v2
that referenced
this pull request
Jul 21, 2021
|
@jasdel @skmcgrail could you please take a look? |
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Nov 5, 2021
Updates the SDK's API clients to include the new WaitForOutput added in smithy-go aws/smithy-go#319 change.
jasdel
approved these changes
Nov 9, 2021
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Nov 10, 2021
Updates the SDK's API clients to include the new WaitForOutput added in smithy-go aws/smithy-go#319 change.
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Nov 10, 2021
Updates the SDK's API clients to include the new WaitForOutput added in smithy-go aws/smithy-go#319 change.
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
Updates the SDK's API clients to include the new WaitForOutput added in smithy-go aws/smithy-go#319 change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-go-v2#1338
Description of changes:
This PR adds a
WaitForOutputmethod to waiters that returns the successful operation's output. This allows the user to avoid making an extra API request to find the full result of the operation that they were waiting for - in my case, I want to access theStandardOutputContenton theGetCommandInvocationOutputusing thessm.NewCommandExecutedWaiter.I opted for adding a method rather than changing the existing
Waitmethod to avoid breaking the interface, but if a breaking change is ok then I'm happy to update this to just change the signature ofWaitto include the output.I've regenerated the SDK code locally and confirmed that the new method works as intended. The generated code changes from 697d3ed can be seen in haines/aws-sdk-go-v2@2ed786e
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.