transport/http: Fix handling of nil and http.NoBody in Request.Build #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/RequestBody
branch
from
f7ed735 to
85c013a
Compare
Updates the smithy-go HTTP Request to correctly handle building the request to an http.Request. HTTP Client Request must not have a non-nil Body if the ContentLength is 0. The client will treat this case as unknown length and use "transfer-encoding": chunked. This breaks Amazon S3 operations like PutObject which require content-length and do not support "transfer-encoding: chunked" Related to aws/aws-sdk-go-v2#1583
jasdel
force-pushed
the
fixup/RequestBody
branch
from
85c013a to
6630cb6
Compare
skmcgrail
approved these changes
Mar 2, 2022
jasdel
added a commit
that referenced
this pull request
Mar 8, 2022
Adds a fix for the HTTP Request setStream to correctly handle empty and empty unseekable teams. This fixes a bug where the HTTP request would attempt to rewind an empty unseekable stream due to assumptions that the stream would be nil if content length is 0. Related to #356
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the smithy-go HTTP Request to correctly handle building the request to an http.Request. HTTP Client Request must not have a non-nil Body if the ContentLength is 0. The client will treat this case as unknown length and use "transfer-encoding": chunked. This breaks Amazon S3 operations like PutObject which require content-length and do not
support "transfer-encoding: chunked"
Related to aws/aws-sdk-go-v2#1583