sort map keys in JSON Document shape encodes #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Discussed offline, and to double clarify, this impacts only the encoding of |
Madrigal
approved these changes
Aug 26, 2025
Contributor
Madrigal
left a comment
Madrigal
left a comment
There was a problem hiding this comment.
This will have a small performance hit for now having to store the keys on a separate slice and sorting, but since we have to do it anyway there's not much we can improve upon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten correspondence about this a handful of times over the last quarter and it appears to be a behavioral requirement for some downstream AWS services in caching scenarios, so I'm just doing it. It also makes unit testing easier.
This DOES NOT cover general map serialization, that will have to be addressed downstream.