Add param binding error check in auth scheme resolution to avoid panic #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
reviewed
Nov 24, 2025
| for (var resolver: resolvers) { | ||
| writer.write("$T(ctx, params, input, options)", resolver.resolver()); | ||
| if (resolver.resolver().getName().equals("bindAuthEndpointParams")) { | ||
| writer.write("err = $T(ctx, params, input, options)", resolver.resolver()); |
Contributor
There was a problem hiding this comment.
I'm not exactly fond of the way is this written. We shouldn't need to branch if you change it so all auth param resolvers by design return errors. As written this could have issues in the future if we add additional bindings that return errors.
I'm not going to block on the review though so either fixandship or leave it.
Contributor
Author
There was a problem hiding this comment.
I got what you mean, I can change all resolvers from go v2 side to return error considering we only have 2 resolvers for now and that could hide some resolver info
lucix-aws
approved these changes
Nov 24, 2025
lucix-aws
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a go v2 issue aws/aws-sdk-go-v2#3234 , user reported panic during auth scheme resolving when calling s3 with invalid region like "example_region" (with invalid underscore). The issue is due to some services' auth resolver uses endpoint param binder as well (e.g. s3 and eventbridge) ahead of endpoint resolution. Since region validation was just added to the endpoint param binder in #612 , when invalid region is passed to call s3/eventbridge, their auth scheme resolver doesn't check error from endpoint param binding and causes panic when dereferencing nil endpoint param. This PR fixes the panic after adding the same error check to auth scheme resolution.