Improve transfer speed & Fix an issue that marks the mod useless #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New commit: Change hostIp to be externalIp which is the public ip of the host, and set it to listen on 0.0.0.0 I don't know how exactly internet works, but at least from my observation, the mod doesn't work for players not in the local network currently. The commit aims to fix that by asking to fill in the public IP. |
msparkles
changed the title
msparkles
changed the title
|
I need to learn how to use Git. |
|
Also fixes a bug where it hangs the server up after typing /stop |
…alIp which is the public ip of the host, and set it to listen on 0.0.0.0, Use BufferedInputStream#transferTo to improve transfer speed
|
Is this ever going to be merged? |
|
Who knows, better to use halotroop's fork of my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.