Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Rust docker image and mark as GA #4134

Closed
Tracked by #4123 ...
ford-at-aws opened this issue Dec 29, 2022 · 1 comment · Fixed by #4279
Closed
Tracked by #4123 ...

Refine Rust docker image and mark as GA #4134

ford-at-aws opened this issue Dec 29, 2022 · 1 comment · Fixed by #4279
Assignees

Comments

@ford-at-aws
Copy link
Contributor

ford-at-aws commented Dec 29, 2022

As an AWS customer, I want to be able to rely on the Docker image found in the Rust language repository to contain all the necessary examples for Rust, including pre-compiled dependencies so that I can effectively run example code in a Docker environment.

I know this is done when:

  • the Dockerfile itself contains correct steps for resolving dependencies and is built successfully
  • the resulting Docker image is successfully pushed to ECR via the existing DevOps processes
  • the container that is created from that image runs some subset of example code (e.g. the Lambda MVP) successfully by exec'ing in, adding AWS credentials, and invoking it via terminal session
  • usage steps explaining which examples can be run and how are documented in the README.md#docker-image section

Adding credentials to your docker container

Never add credentials to a Dockerfile or the resulting image. Instead, add them at runtime using the following command:
docker run -it --volume ~/.aws/credentials:/root/.aws/credentials IMAGE_NAME

You can find IMAGE_NAME by running docker images and copying the first 4 digits of the random Id that's created when you run docker build ..

@cajual
Copy link

cajual commented Jan 10, 2023

@ford-at-aws has the preview been removed? Public ECR doesn't show an available image as of today 01/10/2023.

DavidSouther added a commit to DavidSouther/aws-doc-sdk-examples that referenced this issue Jan 20, 2023
Deps, ignore, etc.

Closes awsdocs#4134
ford-at-aws added a commit that referenced this issue Jan 23, 2023
* Rust Dockerfile GA

Deps, ignore, etc.

Closes #4134

* Use explicit manifest path for cargo check.

Co-authored-by: ford prior <108086978+ford-at-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants