Dockerfile fixes #4377
Merged
Dockerfile fixes #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2023 20:01
Versions of the Swift docker image for version 5.7 and later have differences that prevented the Dockerfile's instructions from working correctly, and did not work with the `swiftbuild` script. This is fixed in this commit thusly: * Changed the Dockerfile to pull the most recent Swift instead of Swift 5.6. This is done because the Swift 5.6 docker image doesn't work for ARM Macs. * Changed the name of `swiftbuild` to `swiftbuild.py` to clarify that it's a Python script. * Changed the Dockerfile to invoke `swiftbuild` by directly executing `python3.10 swiftbuild.py`. This both uses the name for the Python installed on the more recent image and is updated for the new name of the script.
shepazon
added
status/no-text-review-needed
and removed
status/no-text-review-needed
labels
ford-at-aws
added
status/code-review-complete
and removed
status/code-review-needed
labels
lkdavies
added
status/text-review-complete
and removed
status/text-review-needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-doc-sdk-examples Pull Request
Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.
NOTE: This pull request (PR) template contains two sections. Use the section that applies to your submission, and remove the section which doesn't apply.
I'm resolving an issue with an existing code example
Versions of the Swift docker image for version 5.7 and later have differences that prevented the Dockerfile's instructions from working correctly, and did not work with the
swiftbuildscript. This is fixed in this commit thusly:swiftbuildtoswiftbuild.pyto clarify that it's a Python script.swiftbuildby directly executingpython3.10 swiftbuild.py. This both uses the name for the Python installed on the more recent image and is updated for the new name of the script.Confirm you have met the following minimum requirements:
Open source license adherence
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.