Skip to content

Javascript (v3): Bedrock Runtime Agent - Invoke Agent #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2024
Merged

Javascript (v3): Bedrock Runtime Agent - Invoke Agent #6129

merged 4 commits into from
Feb 22, 2024

Conversation

Dinuda
Copy link
Contributor

@Dinuda Dinuda commented Feb 17, 2024

This pull request contains an example with @aws-sdk/client-bedrock-agent-runtime used to invoke an Agent. I have included a test case for the service function.

@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Feb 17, 2024
@Dinuda
Copy link
Contributor Author

Dinuda commented Feb 17, 2024

I couldn't reopen pr #6015 . Submitting with changes @cpyle0819

@cpyle0819
Copy link
Contributor

Hey, @Dinuda, have you looked at our existing "javascriptv3/bedrock-runtime? It has all of this and more. Please double-check and make sure that this PR is needed.

@cpyle0819
Copy link
Contributor

I spoke too soon. I see the difference. Nevermind.

@cpyle0819 cpyle0819 self-assigned this Feb 19, 2024
@cpyle0819 cpyle0819 added Follow After Scouts, more languages are added to examples as Follows. Task A general update to the code base for language clarification, missing actions, tests, etc. and removed Follow After Scouts, more languages are added to examples as Follows. labels Feb 19, 2024
@Dinuda Dinuda requested a review from ford-at-aws as a code owner February 19, 2024 18:23
@cpyle0819 cpyle0819 changed the title JavascriptV3: Invoke Agent Bedrock #6015 Javascript (v3): Bedrock Runtime Agent - Invoke Agent Feb 19, 2024
@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Feb 19, 2024
@DennisTraub
Copy link
Contributor

DennisTraub commented Feb 20, 2024 •
edited
Loading

It looks like this PR changes the quotes in all the model invocation examples in ../bedrock-runtime, which isn't related to bedrock-agent-runtime. I'm trying to keep them consistent across examples.

Question to @cpyle0819: Does it matter from your PoV if some examples use single quotes and some use double quotes for strings?

@cpyle0819
Copy link
Contributor

@DennisTraub Yes, we should be using double quotes. Please see instructions in the .git-hooks folder for setting up commit hooks to run code formatting on commit.

@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Feb 22, 2024
@ford-at-aws ford-at-aws merged commit 3dd97af into awsdocs:main Feb 22, 2024
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Feb 28, 2024
@Dinuda @meyertst-aws
Javascript (v3): Bedrock Runtime Agent - Invoke Agent (awsdocs#6129)
e53d7ca
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
@Dinuda @max-webster
Javascript (v3): Bedrock Runtime Agent - Invoke Agent (awsdocs#6129)
f63017c
@tejasgn1 tejasgn1 mentioned this pull request Jun 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpyle0819 cpyle0819 cpyle0819 approved these changes

@ford-at-aws ford-at-aws Awaiting requested review from ford-at-aws

Assignees

@cpyle0819 cpyle0819

Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dinuda @cpyle0819 @DennisTraub @ford-at-aws