PHP: S3 Express Basics scenario #6975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beqqrry-aws
force-pushed
the
php_s3_express_basics
branch
from
583aef3
to
ec27158
Compare
beqqrry-aws
added
the
Scout
beqqrry-aws
force-pushed
the
php_s3_express_basics
branch
from
ec27158
to
167e547
Compare
beqqrry-aws
force-pushed
the
php_s3_express_basics
branch
from
167e547
to
e9d24b9
Compare
beqqrry-aws
requested review from
a team,
rlhagerm and
ford-at-aws
and removed request for
a team and
rlhagerm
beqqrry-aws
added
the
Basics
ford-at-aws
requested changes
Oct 16, 2024
Comment on lines
+32
to
+36
| /* Inline declaration example | ||
| // snippet-start:[php.example_code.ec2.basics.createClient] | ||
| $ec2Client = new Ec2Client(['region' => 'us-west-2', 'version' => 'latest', 'profile' => 'default']); | ||
| // snippet-end:[php.example_code.ec2.basics.createClient] | ||
| */ |
Comment on lines
+62
to
+68
| public function createVpc($cidr) | ||
| { | ||
| $result = $this->ec2Client->createVpc([ | ||
| "CidrBlock" => $cidr, | ||
| ]); | ||
| return $result['Vpc']; | ||
| } |
There was a problem hiding this comment.
Shouldn't we handle exceptions here?
Comment on lines
+74
to
+79
| public function deleteVpc(mixed $vpcId) | ||
| { | ||
| $result = $this->ec2Client->deleteVpc([ | ||
| "VpcId" => $vpcId, | ||
| ]); | ||
| } |
There was a problem hiding this comment.
Shouldn't we handle exceptions here?
Comment on lines
+85
to
+90
| public function deleteVpcEndpoint(mixed $vpcEndpointId) | ||
| { | ||
| $result = $this->ec2Client->deleteVpcEndpoints([ | ||
| "VpcEndpointIds" => [$vpcEndpointId], | ||
| ]); | ||
| } |
There was a problem hiding this comment.
Shouldn't we handle exceptions here?
Comment on lines
+47
to
+56
| public function createVpcEndpoint(string $serviceName, string $vpcId, array $routeTableIds): array | ||
| { | ||
| $result = $this->ec2Client->createVpcEndpoint([ | ||
| 'ServiceName' => $serviceName, | ||
| 'VpcId' => $vpcId, | ||
| 'RouteTableIds' => $routeTableIds, | ||
| ]); | ||
|
|
||
| return $result["VpcEndpoint"]; | ||
| } |
There was a problem hiding this comment.
Shouldn't we handle exceptions here?
| @@ -0,0 +1,137 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Are there tests for this file?
Comment on lines
+11
to
+17
| <!-- <testsuites>--> | ||
| <!-- <testsuite name="kms-basics">--> | ||
| <!-- <file>kms/tests/KmsBasicsTests.php</file>--> | ||
| <!-- </testsuite>--> | ||
| <!-- <testsuite name="s3-express-basics">--> | ||
| <!-- <file>s3/tests/S3ExpressBasicsTest.php</file>--> | ||
| <!-- </testsuite>--> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request submits the Scout for S3 Express Basics scenario using AWS SDK for PHP v3.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.