Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Weathertop - Plugin updates #7154

Merged
merged 28 commits into from
Dec 13, 2024
Merged

Tools: Weathertop - Plugin updates #7154

merged 28 commits into from
Dec 13, 2024

Conversation

ford-at-aws
Copy link
Contributor

@ford-at-aws ford-at-aws commented Dec 12, 2024 •
edited
Loading

This pull request makes required updates to the Plugin stack:

  • updates to include Batch ephemeral storage default for 30 GiB, as 20 GiB was under the allowable limit (the minimum supported value is 21 GiB and the maximum supported value is 200 GiB.)
  • excluding infra info from cdk.context.json
  • adds termination protection so it's resilient against automated account clean up (future PR)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ford-at-aws ford-at-aws self-assigned this Dec 12, 2024
@github-actions github-actions bot added the Tools This issue relates to a custom tooling to streamline development tasks label Dec 12, 2024
@ford-at-aws ford-at-aws added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Dec 12, 2024
@ford-at-aws ford-at-aws mentioned this pull request Dec 12, 2024
Open
@ford-at-aws ford-at-aws removed the request for review from DavidSouther December 13, 2024 17:07
@ford-at-aws ford-at-aws added the On Call Review needed This work needs an on-call review label Dec 13, 2024
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Dec 13, 2024
@rlhagerm rlhagerm merged commit c58d011 into awsdocs:main Dec 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpyle0819 cpyle0819 cpyle0819 approved these changes

Assignees

@ford-at-aws ford-at-aws

Labels
On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ford-at-aws @cpyle0819 @rlhagerm