Add network isolation for training and processing jobs & Inter container encryption in sagemaker training and hyper parameter tuning job #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encryption in sagemaker training job and hyper parameter tuning job
This comment was marked as outdated.
This comment was marked as outdated.
…encryption in sagemaker training job and hyper parameter tuning job
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
229
to
230
| SUBNET_IDS = json.loads(os.environ["SUBNET_IDS"]), | ||
| SECURITY_GROUP_IDS = json.loads(os.environ["SECURITY_GROUP_IDS"]) |
There was a problem hiding this comment.
- This isn't Python syntax :)
SUBNET_IDSandSECURITY_GROUP_IDSaren't present in environment variables. You'll need to add these two variables as arguments toProduct, and then pass them toBuildPipelineConstructs.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # modules/sagemaker/sagemaker-templates-service-catalog/templates/xgboost_abalone/product_stack.py
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # CHANGELOG.md
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mahesh-balumuri
pushed a commit
to mahesh-balumuri/mlops-modules
that referenced
this pull request
Aug 25, 2024
…ner encryption in sagemaker training and hyper parameter tuning job (awslabs#133) * add KMS encryption for storage * adding encryption to ECR * Encrypting each bucket with KMS MANAGED * Network isolation for training and processing jobs & Inter container encryption in sagemaker training job and hyper parameter tuning job * Network isolation for training and processing jobs & Inter container encryption in sagemaker training job and hyper parameter tuning job * checkpoint * Initial changes based on PR comments * Re-arrange imports for validation script * Convert lists to env vars correctly * Create SG in module * Resolve VPC in catalog stack instead of product stack * Formatting * Add permissions * Do not enable network isolation on preprocess * Updated changelog --------- Co-authored-by: Srinivas Reddy <srinivasreddych@outlook.com> Co-authored-by: Leon Luttenberger <LeonLuttenberger@users.noreply.github.com> Co-authored-by: Anton Kukushkin <kukushkin.anton@gmail.com> Co-authored-by: Ethan Bunce <ebunce@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.