chore: release 1.7.0 #261
Merged
chore: release 1.7.0 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
EthanBunce
reviewed
Oct 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
EthanBunce
approved these changes
Oct 25, 2024
clokep
reviewed
Oct 25, 2024
| @@ -45,7 +45,7 @@ parameters: | |||
| usage: core | |||
| - eks_ng_name: ng-gpu | |||
| eks_node_quantity: 6 | |||
| eks_node_max_quantity: 15 | |||
| eks_node_max_quantity: 10 | |||
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
Yes, thank you for checking though. 15 instances is an overkill for this training so I thought might as well save customers some $ :)
clokep
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.