Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sagemaker-custom-kernel module permissions #64

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

kukushking
Copy link
Contributor

Describe your changes

  • removed ECR IAM permissions from sagemaker-custom-kernel's modulestack.yaml as ECR deployment is handled by CDK

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
@kukushking kukushking changed the title fix: sagemaker-custom-kernel module permissions fix: sagemaker-custom-kernel module permissions Apr 19, 2024
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
@kukushking kukushking merged commit b6371b9 into awslabs:main Apr 19, 2024
11 checks passed
@kukushking kukushking deleted the fix/sagemaker-custom-kernel-iam branch April 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants