feat: multi account basic template self mutating pipeline #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
model_build: self-mutating pipeline poc - changes from Anton
…pdated cdk deploy commands
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
LeonLuttenberger
requested changes
May 15, 2024
...tes-service-catalog/templates/model_deploy/seed_code/deploy_app/deploy_app/pipeline_stack.py
Outdated
Show resolved
Hide resolved
...tes-service-catalog/templates/model_deploy/seed_code/deploy_app/deploy_app/pipeline_stack.py
Outdated
Show resolved
Hide resolved
modules/sagemaker/sagemaker-templates-service-catalog/templates/model_deploy/product_stack.py
Outdated
Show resolved
Hide resolved
modules/sagemaker/sagemaker-templates-service-catalog/templates/model_deploy/product_stack.py
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
…n't function as expected
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
kukushking
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Upon testing this there is two items that I have noticed:
- The initial CodeBuild upon approving the model, attempts to deploy the application but does not succeed because there are multiple stacks. I think we need to change the buildspec to only deploy the pipeline stack (and supporting cross-region stacks that will be deployed automatically.
Since this app includes more than a single stack, specify which stacks to use (wildcards are supported) or specify `--all`
196 | Stacks: deploy-1-pipeline · cross-region-stack-...:... · deploy-1-pipeline/dev/endpoint · deploy-1-pipeline/preprod/endpoint · deploy-1-pipeline/prod/endpoint
- We need to add a lambda custom resource trigger to call the initial CodeBuild to synth and deploy the pipeline once.
Otherwise looks great, thank you!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
reviewed
Jul 11, 2024
modules/sagemaker/sagemaker-templates-service-catalog/templates/model_deploy/product_stack.py
Show resolved
Hide resolved
kukushking
reviewed
Jul 11, 2024
modules/sagemaker/sagemaker-templates-service-catalog/templates/model_deploy/product_stack.py
Outdated
Show resolved
Hide resolved
kukushking
previously approved these changes
Jul 11, 2024
kukushking
reviewed
Jul 12, 2024
...tes-service-catalog/templates/model_deploy/seed_code/deploy_app/deploy_app/pipeline_stack.py
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
approved these changes
Jul 16, 2024
LeonLuttenberger
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.