Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awslabs to git safe dir #802

Merged
merged 2 commits into from
May 2, 2024
Merged

Add awslabs to git safe dir #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca63e5
Add awslabs to git safe dir
ktasper May 2, 2024
88e0a9b
SHA in makefile & comments
ktasper May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ WINDOWS_ARM64_BINARY=$(BINPATH)/windows-arm64/$(BINARY_NAME).exe
.PHONY: docker
docker: build-in-docker

%-in-docker:
%-in-docker: GITCOMMIT_SHA
docker run --rm \
--user $(UID):$(GID) \
--env TARGET_GOOS=$(TARGET_GOOS) \
Expand Down
3 changes: 3 additions & 0 deletions scripts/container_init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ apk add --no-cache \
# Resolves permission issues for Go cache when
# building credential helper as non-root user.
mkdir /.cache && chmod 777 /.cache
# Resolves dubious ownership of git directory when
# building credential helper as root user.
git config --global --add safe.directory /go/src/github.com/awslabs/amazon-ecr-credential-helper
ktasper marked this conversation as resolved.
Show resolved Hide resolved

Loading