Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better to keep AWS CLI version aligned #1134

Closed
guessi opened this issue Dec 17, 2022 · 2 comments · Fixed by #1135
Closed

Better to keep AWS CLI version aligned #1134

guessi opened this issue Dec 17, 2022 · 2 comments · Fixed by #1135

Comments

@guessi
Copy link
Member

guessi commented Dec 17, 2022 •
edited
Loading

What would you like to be added:

Keep the AWS CLI version aligned.

Why is this needed:

Recently introduced AWS CLI v2 into build scripts at #1066 and fix the path issue later on #1102.

However, there are still 2 more scripts will try to setup AWS CLI v1 if user try to run log-collector-script with SSM,

Which might cause inconsistent AWS CLI output if there's some $PATH order issue.

After checking commit history, the scripts were introduced 3 years ago

Discussion:

  • Do we need to install AWS CLI if we had already have it installed while baking AMI? maybe we should remove it?
@cartermckinnon
Copy link
Member

Do we need to install AWS CLI if we had already have it installed while baking AMI? maybe we should remove it?

The log collector script is intended to be minimally useful on custom AMI's, which may not already have the AWS CLI. Feel free to PR the script to install v2 instead of v1.

@guessi
Copy link
Member Author

guessi commented Dec 19, 2022

Will do 👍

@guessi guessi mentioned this issue Dec 19, 2022
Merged
guessi added a commit to guessi/amazon-eks-ami that referenced this issue Dec 29, 2022
@guessi
Refresh Log Collector Scripts for SSM
b83835e 
* Cleanup HTML code from README.md
* Update AWS CLI version from v1 to v2
* Refresh sample command outputs for v0.7.3
* Remove dummy "PatchLinux" for Windows nodes
* Remove dummy "PatchWindows" for Linux nodes
* Rename SSM document for Linux from "EKSLogCollector" to "EKSLogCollectorLinux"
* Rename SSM document for Windows from "EKSLogCollector" to "EKSLogCollectorWindows"
* Explicitly defined permissions for run `aws ssm ...` commands

Fixes awslabs#1134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refresh Log Collector Scripts for SSM guessi/amazon-eks-ami
2 participants
@guessi @cartermckinnon