Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run shellcheck on test case files #1061

Closed
wants to merge 1 commit into from
Closed

run shellcheck on test case files #1061

wants to merge 1 commit into from

Conversation

steved
Copy link
Contributor

@steved steved commented Oct 26, 2022

Issue #, if available:

N/A

Description of changes:

Looks like there was an abortive attempt in #599, but it seems like a decent idea to lint the test case files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

N/A

@steved
Copy link
Contributor Author

steved commented Oct 26, 2022

cc @cartermckinnon @mmerkes

@cartermckinnon
Copy link
Member

Thanks for bringing this up! I've added shfmt targets to the makefile, and the shellcheck change will be covered in #1068 .

@steved steved deleted the steved/shellcheck branch October 31, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steved @cartermckinnon