Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify region for local zones in sandbox image ecr auth #1626

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ndbaker1
Copy link
Member

@ndbaker1 ndbaker1 commented Feb 5, 2024

Issue #, if available:

Description of changes:

Fix aws cli behavior pertaining to issue aws/aws-cli#7043 for sandbox image pulling script (#1605)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@cartermckinnon
Copy link
Member

/ci launch

Copy link
Contributor

github-actions bot commented Feb 5, 2024

@cartermckinnon roger that! I've dispatched a workflow. 👍

Copy link
Contributor

github-actions bot commented Feb 5, 2024

@cartermckinnon the workflow that you requested has completed. 🎉

Kubernetes versionBuildLaunchTest
1.23success ✅success ✅skipped ⏭️
1.24success ✅success ✅skipped ⏭️
1.25success ✅success ✅skipped ⏭️
1.26success ✅success ✅skipped ⏭️
1.27success ✅success ✅skipped ⏭️
1.28success ✅success ✅skipped ⏭️
1.29success ✅success ✅skipped ⏭️

@cartermckinnon cartermckinnon changed the title use region in sandbox image for ecr auth Pass region for local zones in sandbox image for ecr auth Feb 5, 2024
@cartermckinnon cartermckinnon changed the title Pass region for local zones in sandbox image for ecr auth Specify region for local zones in sandbox image for ecr auth Feb 5, 2024
@cartermckinnon cartermckinnon changed the title Specify region for local zones in sandbox image for ecr auth Specify region for local zones in sandbox image ecr auth Feb 5, 2024
@cartermckinnon cartermckinnon merged commit 107df3f into awslabs:master Feb 5, 2024
1 of 2 checks passed
@ndbaker1 ndbaker1 deleted the ecr-auth branch February 5, 2024 22:05
atmosx pushed a commit to gathertown/amazon-eks-ami that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants