-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify a user data file #1687
Add ability to specify a user data file #1687
Conversation
Sometimes we need to execute some actions on the instance along with the eks build script but currently there is not a way to inject these additional steps as part of the existing build process. This change adds the ability to specify `user_data_file` which can be passed to the build instance on startup.
i agree! nice way to help decouple |
@cartermckinnon since this is an acceptable improvement, can we merge this? |
/ci build |
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
@cartermckinnon the workflow that you requested has completed. 🎉
|
@AlexSchultz-clumio you need to add a default value for this variable in the respective
Empty string should do it 👍 |
Got it. Will fix thanks
|
/ci |
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
@cartermckinnon the workflow that you requested has completed. 🎉
|
Issue #, if available:
Description of changes:
Sometimes we need to execute some actions on the instance along with the eks build script but currently there is not a way to inject these additional steps as part of the existing build process. This change adds the ability to specify
user_data_file
which can be passed to the build instance on startup.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Built a new image with
make k8s=1.29 user_data_file=test.yaml
The
test.yaml
contained severalbootcmd
andruncmd
options to tweak the base image being used:Deployed built AMI to cluster and verified pods were able to be schedule and use the node. Also verified the actions were run during the build process and the results showed up in the built AMI.