Update readme for building AL2023 AMI #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
reviewed
Feb 29, 2024
README.md
Outdated
| @@ -33,11 +33,14 @@ invoking Packer directly. You can initiate the build process by running the | |||
| following command in the root of this repository: | |||
|
|
|||
| ```bash | |||
| # build an AMI with the latest Kubernetes version | |||
| # build an AL2 AMI with the latest Kubernetes version | |||
There was a problem hiding this comment.
now that we've built the story for multiple os distros, should we just say default?
Suggested change
| # build an AL2 AMI with the latest Kubernetes version | |
| # build an AMI with the latest Kubernetes version and the default OS distro |
keeping the AL2 hint maybe, default OS distro (AL2)
ndbaker1
approved these changes
Feb 29, 2024
cartermckinnon
added
the
changelog/exclude
atmosx
pushed a commit
to gathertown/amazon-eks-ami
that referenced
this pull request
Jun 18, 2024
* Update readme for building AMI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.