Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect IPv6 Networking Information in Log Collector Script #1693

Closed
wants to merge 9 commits into from
Closed

Collect IPv6 Networking Information in Log Collector Script #1693

wants to merge 9 commits into from

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Feb 29, 2024

Issue #, if available:
#1474

Description of changes:
This PR updates the log collector script for Linux nodes to collect IPv6 networking information that will assist in debugging. The following commands are run on IPv4 and IPv6 nodes:

  1. ip6tables --wait 1 --numeric --verbose --list --table mangle
  2. ip6tables --wait 1 --numeric --verbose --list --table filter
  3. ip6tables --wait 1 --numeric --verbose --list --table nat
  4. ip6tables --wait 1 --numeric --verbose --list
  5. ip6tables-save
  6. timeout 75 conntrack -L -f ipv6
  7. timeout 75 ip -6 rule show
  8. timeout 75 ip -6 route show table all

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

I ran the updated script against IPv4 and IPv6 Linux nodes and validated that the expected information was collected.

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@cartermckinnon cartermckinnon changed the base branch from master to main February 29, 2024 20:39
get_network_policy_ebpf_info() {
try "collect network policy ebpf loaded data"
echo "*** EBPF loaded data ***" >> "${COLLECT_DIR}"/networking/ebpf-data.txt
LOADED_EBPF=$(/opt/cni/bin/aws-eks-na-cli ebpf loaded-ebpfdata | tee -a "${COLLECT_DIR}"/networking/ebpf-data.txt)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test for the presence of this binary aws-eks-na-cli before using it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sine this is already merged, not sure why this is here in this diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this came from either Carter committing directly to this branch or fallout from the name of the primary branch being changed to main. Either way, I will delete and recreate this PR to fix it

Copy link

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,5 +27,5 @@ jobs:
- run: git remote add codecommit ${{ secrets.AWS_CODECOMMIT_REPO_URL }}
- run: git checkout master
- run: git push codecommit master
- run: git checkout al2023
- run: git push codecommit al2023
- run: git checkout main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to revert the unintentional changes in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These came from Carter committing to this branch. Not sure what is happening there, so I will reach out to him

@jdn5126 jdn5126 closed this by deleting the head repository Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants